Do not ignore Consumer.Offsets.AutoCommit.Enable config on Close #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can somebody kick the builds again please, looks like a test environment issue. Thx! |
|
@wclaeys can you try: I don't see the option to re-run the action. It might be configured to run only when pushed |
|
This PR needs to be rebased off of master — it uses no longer supported GitHub Actions features that were fixed in master recently. |
d1egoaz
approved these changes
Jan 12, 2021
bai
approved these changes
Jan 13, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
om.conf.Consumer.Offsets.AutoCommit.Enableduring closing of theoffset_managerand hence fixing #1843